So let's start with the problems, this time regarding installing the mod.
I've noticed the custom music feature is slightly broken by the Mod Loader, meaning the vanilla music is not used unless that's copied in the mod directory. So I thought, it's possible to set the Inno Setup installer to copy automatically those files and place them in the right folder? Or does any of you have a better solution (like fixing the bug in the first place)? And before you suggest it, I won't place those mp3 directly in the mod (I don't want to face copyright problems....)
So let's start with the problems, this time regarding installing the mod.
I've noticed the custom music feature is slightly broken by the Mod Loader, meaning the vanilla music is not used unless that's copied in the mod directory. So I thought, it's possible to set the Inno Setup installer to copy automatically those files and place them in the right folder? Or does any of you have a better solution (like fixing the bug in the first place)? And before you suggest it, I won't place those mp3 directly in the mod (I don't want to face copyright problems....)
No solution from me, sorry. Your idea of copying the files sounds like a good plan though. By the way, is it illegal to redistribute the mp3 files? I was under the impression that any file contained within the original package is fair game to include as part of a non-commercial modification, even if it is licensed content. Is that not how it works?
I don't have CE reborn available so I can't be sure, but I think I found the problem. I made a change in fileutil.py in def:copyfile:
The version from CE looks like this: def copyfile(src, dst): """Copy data from src to dst""" # (extracted from python 2.1.2 : shutil.py)
if (-1 == src.find("\\"+moddir+"\\") and -1 == src.find("\\vampire\\")): print "fileutil : copyfile - source directory Invalid" return
In fileutil from the patch there is only the part about "moddir". So if you try to copy from /vampire, the function doesn't work. I made this edit to the function to be able to copy files from /vampire as well as from the moddir.
Maybe Wesp could use this as well, so other modders will be able to copy files from both, their directory and /vampire.
Maybe Wesp could use this as well, so other modders will be able to copy files from both, their directory and /vampire.
I'm not good enough at Python to understand what you did there, I believe EntenSchreck or somebody else wrote the patch script, but wouldn't this be problematic for the patch when e.g. in case of the hunter/vampire switch original game files were used instead of the patched ones?
Basically the copy function works in three parts: first, make sure the source file is valid; i.e. part of the bloodlines installation. second, make sure the destination is valid. Again, part of the bloodlines installation. third, the process of copying the files.
Back in the day when the fileutil script was written, I think by Dheu, there was only /vampire. So he made sure that every file operation can only use files within the /vampire directory. Later when we had the mod loader, /vampire was replaced in those checks by "moddir". Now any file operation can only be done when all files involved are part of the mod. I think this is a bit restricting, so I made a change to allow /vampire as well as the mod directory as source, but not destination, of copy operations. The change does not allow to modify any of the original files, but modders who need to switch between original and modded files don't have to put the original file into their installer.
As for the hunter/vampire switch, these scripts are already written and extending the source file options does not affect their functionality.
Doesn't something like this work in Inno? Long time since I've been near that program. Extremely long time, so, I may not be remembering how to use it correctly. Paths may need played with. Kind of from Wesp5 shared script but maybe the answer lays within that for {app}
With a few modifications the code works: ; CE music fix Source: "{app}\Vampire\sound\music\*"; DestDir: "{app}\CE_reborn\sound\music\"; Flags: external recursesubdirs overwritereadonly ignoreversion skipifsourcedoesntexist
Thank you all, now for the annoying part, uploading.... XD
Post by Caedia Veness on Jul 27, 2024 13:33:33 GMT
I don't normally possess a need to micromanage the contents of forum posts unless they're in violation of the appropriate conduct, but I genuinely could not even continue to browse this thread with that .gif posted to here, it was truly so much of an offense to the eyes, nevermind that the context behind it's posting was evidently somewhat confusing.
I don't normally possess a need to micromanage the contents of forum posts unless they're in violation of the appropriate conduct, but I genuinely could not even continue to browse this thread with that .gif posted to here, it was truly so much of an offense to the eyes, nevermind that the context behind it's posting was evidently somewhat confusing.
Nothing, but a stupid piece of my sense of humour that gif. It did have the guys name on Tenor and wasn't intended as anything other than silly.
I'll refrain in future from trying to inject my silly humour in such a way in a serious modding thread. There was no ill intent meant and I can see why it was confusing.
The guy is quite unsettling.
Edit: In all fairness. I searched 'giggity' on Tenor and looking for Quagmire to post. The guy has 6 Million+ YouTube subs and is named Ricky Berwick from the gif.
Social Media